Skip to content

feat: support passing profile init option #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2019
Merged

feat: support passing profile init option #321

merged 4 commits into from
Feb 11, 2019

Conversation

alanshaw
Copy link
Member

@ghost ghost assigned alanshaw Feb 11, 2019
@ghost ghost added the status/in-progress In progress label Feb 11, 2019
@alanshaw alanshaw mentioned this pull request Feb 11, 2019
Merged
1 task
feat: support passing profile init option
3ec28af 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw force-pushed the feat/support-profile branch from 9f1f024 to 3ec28af Compare February 11, 2019 13:02
daviddias
daviddias requested changes Feb 11, 2019
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the tests on this module to use this option? While you are at it, can you also measure the time difference?

Thank you!

Alan Shaw added 2 commits February 11, 2019 15:42
fix: only use profile for go-ipfs, not supported in js-ipfs yet
9c39d05 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
refactor: use test profile in tests
141aeff 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
Copy link
Member Author

Before: 4m8.412s
After: 3m11.664s

refactor: log when ignoring profile option
d5687e4 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@daviddias daviddias merged commit 62a15d2 into master Feb 11, 2019
@daviddias daviddias deleted the feat/support-profile branch February 11, 2019 20:11
@ghost ghost removed the status/in-progress In progress label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@alanshaw alanshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @daviddias