This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: update example with public webrtc servers #3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add it to the config browser swarm addresses? |
vasco-santos
force-pushed
the
chore/update-browser-example-with-public-webrtc-servers
branch
from
b62472a to
6e9ba8a
Compare
achingbrain
suggested changes
Jun 26, 2020
Sure, I agree with that! I just want to make sure the tests work first with the setup infrastructure |
vasco-santos
force-pushed
the
chore/update-browser-example-with-public-webrtc-servers
branch
from
6e9ba8a to
163f6f8
Compare
vasco-santos
force-pushed
the
chore/update-browser-example-with-public-webrtc-servers
branch
3 times, most recently
from
0a14dda to
bec6153
Compare
vasco-santos
force-pushed
the
chore/update-browser-example-with-public-webrtc-servers
branch
from
bec6153 to
6685ec7
Compare
achingbrain
approved these changes
Jul 1, 2020
achingbrain
deleted the
chore/update-browser-example-with-public-webrtc-servers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #2779 , this PR adds the public webrtc servers to the browser example.
This allows users to run easily the example, but also provides information for how users should use a signaling server for production.