This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: Unlink files locally #1043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
reviewed
Oct 20, 2017
src/core/components/files.js
Outdated
| @@ -120,6 +120,23 @@ module.exports = function files (self) { | |||
| getPull: promisify((ipfsPath, callback) => { | |||
| callback(null, exporter(ipfsPath, self._ipldResolver)) | |||
| }) | |||
There was a problem hiding this comment.
Looks like you forgot a comma at the end of this function. I think that's why the build failed.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the method
unlinkto thefilescomponent.I have read the discussiones (here & here) and understand files are not deleted from the network (if another peer has pinned them, then the files can still be distributed).
We are working on a web project where we add files to the network and we wanted to remove the files to clear some space locally. With this method the files get
unlinkedlocally.