integrated local-extract and aded to the dashboard #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mcollina
reviewed
Nov 22, 2018
runner/config.js
Outdated
| }, | ||
| { | ||
| name: 'unixFS-extract', | ||
| shell: `source ~/.nvm/nvm.sh && OUT_FOLDER=/tmp/out REMOTE=true node ${remoteTestsPath}/local-extract.js`, |
There was a problem hiding this comment.
Can you extract the source ~/.nvm/nvm.sh && OUT_FOLDER=/tmp/out REMOTE=true part into a variable? So we don't repeat this everywhere with the risk of forgetting one.
| @@ -23,7 +23,7 @@ const writePoints = (data) => { | |||
| for (let point of data) { | |||
| payload.push({ | |||
| measurement: point.name, | |||
| tags: { subTest: point.subTest, commit: point.meta.commit, project: point.meta.project, testClass: point.testClass }, | |||
| tags: { subTest: point.subtest, commit: point.meta.commit, project: point.meta.project, testClass: point.testClass }, | |||
There was a problem hiding this comment.
Ron used lowercase i used snakeCase. We should probably unify that everywhere ;-)
|
|
||
| arrResults.push(await localAdd(node, testName, 'add-populated-repo', 'largefile')) | ||
| arrResults.push(await localAdd(node, testName, 'populated-repo', 'largefile')) |
There was a problem hiding this comment.
can you refactor this block by iterating over the list of tests (maybe from config)?
There was a problem hiding this comment.
yep, I will make a new PR though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.