This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: tests of addFromURL in browsers #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
added a commit
to lidel/js-ipfs
that referenced
this pull request
Aug 27, 2019
Context: ipfs-inactive/interface-js-ipfs-core#514 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
7 tasks
lidel
added a commit
to lidel/js-ipfs
that referenced
this pull request
Aug 28, 2019
Context: ipfs-inactive/interface-js-ipfs-core#514 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
hugomrdias
approved these changes
Aug 28, 2019
hugomrdias
suggested changes
Aug 28, 2019
hugomrdias
approved these changes
Aug 28, 2019
|
@lidel it took me a while to figure out that there's a noop server in the browser. What do you think about requiring the echo server to be started in all environments? 1) It would simplify the setup and teardown code in the tests here, 2) we wouldn't need a noop server (potentially helping with any misunderstandings) and 3) it would only need a couple of changes to .aegir.js (which you're already editing in that PR) to also start it for Node.js. |
|
@alanshaw if we are going to simplify this, I'd like to also remove HTTPS echo server and have only HTTP instance, as suggested in ipfs/js-ipfs#2304 (comment). I fail to see what is the value of testing HTTPS. Y/n? |
|
@lidel go for it! |
lidel
added a commit
that referenced
this pull request
Aug 30, 2019
This simplifies the way we use HTTP Echo Server by moving it to aegir hooks and removing HTTPS version. Context: #514 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
to lidel/js-ipfs
that referenced
this pull request
Aug 30, 2019
This simplifies code in interface-js-ipfs-core as both Node an Browser init it the same way Context: ipfs-inactive/interface-js-ipfs-core#514 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
|
@alanshaw check a810adf and ipfs/js-ipfs@32e76cc |
alanshaw
approved these changes
Aug 30, 2019
lidel
added a commit
to lidel/js-ipfs
that referenced
this pull request
Sep 4, 2019
Context: ipfs-inactive/interface-js-ipfs-core#514 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
to lidel/js-ipfs
that referenced
this pull request
Sep 4, 2019
This simplifies code in interface-js-ipfs-core as both Node an Browser init it the same way Context: ipfs-inactive/interface-js-ipfs-core#514 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Old version was Node-centric and did not work in web browser contexts. This change: - moves the HTTP server to separate file to enable spawning it from aegir hook (see .aegir.js/hooks/browser/pre|post in js-ipfs) - removes overhead of starting and stopping HTTP servers multiple times - simplifies test code License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This simplifies the way we use HTTP Echo Server by moving it to aegir hooks and removing HTTPS version. Context: #514 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
fix/addFromURL-in-browser
branch
from
a810adf to
fd2892b
Compare
|
Rebased, no conflicts. |
alanshaw
approved these changes
Sep 5, 2019
lidel
added a commit
to lidel/js-ipfs
that referenced
this pull request
Sep 5, 2019
Context: ipfs-inactive/interface-js-ipfs-core#514 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
to lidel/js-ipfs
that referenced
this pull request
Sep 5, 2019
This simplifies code in interface-js-ipfs-core as both Node an Browser init it the same way Context: ipfs-inactive/interface-js-ipfs-core#514 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old version of
addFromURLtests was Node-centric and did not work in web browser contexts.This PR:
aegir hook (see .aegir.js/hooks/browser/pre|post in js-ipfs from fix: limit concurrent HTTP requests in browser ipfs/js-ipfs#2304)