Skip to content

demo(list): add inset background color for dark mode #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

reslear
Copy link
Contributor

@reslear reslear commented Jun 22, 2023

also maybe need add this style to global ionic theme?

before after
Screenshot 2023-06-23 at 00 05 52 Screenshot 2023-06-23 at 00 05 31

also maybe need add this style to global ionic theme?
@vercel
Copy link

vercel bot commented Jun 22, 2023

@reslear is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@reslear reslear changed the title add inset list background color demo: add inset list background color Jun 22, 2023
@reslear reslear changed the title demo: add inset list background color demo(list): add inset background color for dark mode Jun 22, 2023
@liamdebeasi
Copy link
Contributor

Thanks for the PR! I was able to fix this using the light color palette on ion-content to account for both light and dark mode: #3015

I am going to close this in favor of the linked PR, but I will give you co-author credit when it merges.

@liamdebeasi liamdebeasi closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants