Skip to content

fix position <ion-router-outlet> on html #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

skytern
Copy link
Contributor

@skytern skytern commented May 13, 2023

Because the position it's wrong, the position inside create duplication and we don't change tab.

Because the position it's wrong, the position inside <ion-tabs> create duplication <ion-router-outlet> and we don't change tab.
@vercel
Copy link

vercel bot commented May 13, 2023

@skytern is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@sean-perkins
Copy link
Contributor

Hello @skytern thanks for submitting this fix!

The ion-router-outlet isn't needed in Angular with ion-tabs, that is a mistake on our end. I updated the docs for v6 and v7 in this PR: #2965 and gave you co-authored-by credit.

Thanks for helping us improve the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants