feat: use nullable limits and openapi-compliant uniqueness for access schema #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wilsonianb
reviewed
Nov 3, 2022
openapi/schemas.yaml
Outdated
| @@ -259,6 +242,7 @@ components: | |||
| title: limits-outgoing | |||
| description: Open Payments specific property that defines the limits under which outgoing payments can be created. | |||
| type: object | |||
| nullable: true | |||
There was a problem hiding this comment.
I'm struggling to find nullable in OpenAPI or JSON Schema docs
There was a problem hiding this comment.
There was a problem hiding this comment.
It looks like nullable was removed in OpenAPI 3.1
https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0
wilsonianb
reviewed
Nov 3, 2022
openapi/schemas.yaml
Outdated
| type: object | ||
| type: | ||
| - object | ||
| - null |
There was a problem hiding this comment.
Based on examples, I'm seeing at least null (and maybe object) might need to be a "value"
Suggested change
| - null | |
| - 'null' |
OAI/OpenAPI-Specification#2244 (comment)
Not sure if that will resolve the validator errors
wilsonianb
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses (but doesn't really fix) interledger/rafiki#630. This spec is less strict to allow valid responses from the AS to pass validation, but is a bit too loose for what we actually want to achieve with it. The main restriction that this doesn't cover is:
typeof access.