[SYCL][E2E] Fix LIT requires vulkan directive #18348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of "vulkan" to `config.available_features` was moved to `bindless_images/lit.local.cfg` in intel#18220. This broke the `// REQUIRES: vulkan` directive, and tests were reporting as being unsupported despite vulkan being available on the system. This patch moves the check and addition of vulkan to the available features back to `test-e2e/lit.cfg.py` to fix the issue.
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
approved these changes
May 7, 2025
DBDuncan
approved these changes
May 7, 2025
sergey-semenov
approved these changes
May 7, 2025
|
@intel/llvm-gatekeepers This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of "vulkan" to
config.available_featureswas moved tobindless_images/lit.local.cfgin #18220. This broke the// REQUIRES: vulkandirective, and tests were reporting as being unsupported despite vulkan being available on the system.This patch moves the check and addition of vulkan to the available features back to
test-e2e/lit.cfg.pyto fix the issue.