Skip to content

[CI][Perf] Fix sorting benchmark results files #18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PatKamin
Copy link
Contributor

@PatKamin PatKamin commented May 6, 2025

Sort datetime objects instead of strings to get the proper result files list

@PatKamin PatKamin requested a review from a team as a code owner May 6, 2025 12:07
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check that this fixes the markdown output problem?

@pbalcer
Copy link
Contributor

pbalcer commented May 6, 2025

Formatting is failing. In the benchmarks dir:

pip install black
black .

Sort datetime objects instead of strings to get the proper result files
list.
@PatKamin PatKamin force-pushed the fix-bench-files-sorting branch from 4e009fc to 434b968 Compare May 6, 2025 12:21
@PatKamin PatKamin temporarily deployed to WindowsCILock May 6, 2025 12:22 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock May 6, 2025 12:40 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock May 6, 2025 12:40 — with GitHub Actions Inactive
@PatKamin
Copy link
Contributor Author

PatKamin commented May 9, 2025

The markdown issue seem to be unrelated with this change. Closing PR as the current implementation seem to work as expected.

@PatKamin PatKamin closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants