Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SYCL] Allocate SubmissionInfo completely on stack #18314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Allocate SubmissionInfo completely on stack #18314
Changes from 7 commits
3394a1d
2ccf7e8
9d553e0
0af903f
2010156
c85c9df
5633d3e
294b9b1
62995ce
3ff069a
496105f
b5fd0b5
c174746
46c7b28
910d142
ac58752
aa238c5
c3afb5e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way one particular data structure claims entire
sycl::detail::vN
namespace, so that we can't use the same approach for other APIs (that's the same reason why I think oursycl::_v1
turned out to be rather useless). IMO, it would be better to havedetail::submission_info::_v1::SubmissionInfo
or something like that. Maybe makesubmission_info
inline itself.