[UR][Test] Expose UR_CONFORMANCE_TARGET_TRIPLES to tests #18280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maetveis
force-pushed
the
test-expose-ur-conformance-targets
branch
from
0f7fcdb to
b36dce1
Compare
|
What is the use case for this? Would a solution involving |
Forward the value of UR_CONFORMANCE_TARGET_TRIPLES as an array to the conformance tests, and make it available to tests via `KernelsEnvironment::HaveSourcesForTarget(target_name)`. This allows tests to require specific targets to be available.
Maetveis
force-pushed
the
test-expose-ur-conformance-targets
branch
from
b36dce1 to
44bd62b
Compare
RossBrunton
reviewed
May 6, 2025
| @@ -240,6 +241,14 @@ KernelsEnvironment::getKernelSourcePath(const std::string &kernel_name, | |||
| return path.str(); | |||
| } | |||
|
|
|||
| bool KernelsEnvironment::HaveSourcesForTarget(const std::string &target_name) { | |||
| auto it = std::find_if( | |||
There was a problem hiding this comment.
std::any_of might be more idiomatic here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward the value of UR_CONFORMANCE_TARGET_TRIPLES as an array to the conformance tests, and make it available to tests via
KernelsEnvironment::HaveSourcesForTarget(target_name). This allows tests to require specific targets to be available.