Skip to content

Switch to bslib #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Switch to bslib #259

wants to merge 1 commit into from
+63 −62

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented May 7, 2025

Closes #250

@vedhav vedhav added the core label May 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@vedhav
Copy link
Contributor Author

vedhav commented May 7, 2025

I have read the CLA Document and I hereby sign the CLA

@averissimo
Copy link
Contributor

@vedha do you think we should change the CSS color to a bslib variable (#e3e3e3 -> var(--bs-gray-200))

@llrs-roche
Copy link

@vedhav FYI: if the remaining changes are like this I don't see a conflict with the extraction feature:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to bslib
3 participants
@vedhav @averissimo @llrs-roche