Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-22-165] Switch to Nix for cardano-sl build used for genesis generation #1027

Closed
wants to merge 3 commits into from

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Jun 25, 2017

We are slowly switching all deployment-related operations to operate from an environment established by nix-shell entered in iohk-nixops.

This is a part of this unification process, and it makes the genesis generation script use Nix to provide the cardano-sl build.

This makes the routine cd pkgs; ./generate.sh invocation (inside iohk-nixops) a prerequisite for genesis itself -- but this already is a prerequisite for deployment anyway.

Purely dev-based scenarios will change, though.

@mention-bot
Copy link

@deepfire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgeee and @denisshevchenko to be potential reviewers.

@domenkozar
Copy link
Contributor

domenkozar commented Jun 26, 2017

This script should really be refactored and part of iohk-nixops I think.

But for now we can use this change with nix-shell.

@deepfire CI is failing

@deepfire
Copy link
Contributor Author

@domenkozar, the errors were transient, network-related -- restarting helped

@deepfire
Copy link
Contributor Author

@domenkozar, the CI passed -- a simple restart helped

@deepfire
Copy link
Contributor Author

deepfire commented Jul 6, 2017

@domenkozar, can you think of any further actions we need here?

@domenkozar
Copy link
Contributor

yes, this has to wait until we have stack2nix based PRs as currently stack is the tool for building cardano-sl.

@gromakovsky gromakovsky changed the base branch from cardano-sl-0.5-rc to cardano-sl-0.5 July 7, 2017 11:31
@gromakovsky
Copy link
Contributor

I changed base branch to cardano-sl-0.5. It shouldn't change anything. cardano-sl-0.5-rc will be removed.

@georgeee
Copy link
Contributor

georgeee commented Jul 9, 2017

yes, this has to wait until we have stack2nix based PRs as currently stack is the tool for building cardano-sl.

Agrees

Copy link
Contributor

@georgeee georgeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should wait till nix is used as primary development tool for building things

@jagajaga
Copy link
Contributor

jagajaga commented Sep 7, 2017

Ping all

@gromakovsky
Copy link
Contributor

Is it obsolete now?

@domenkozar
Copy link
Contributor

@georgeee Is scripts/generate/genesis.sh obsolete now? If so, we can close this.

@deepfire
Copy link
Contributor Author

Closing as obsolete.

@deepfire deepfire closed this Oct 17, 2017
@deepfire deepfire deleted the devops-22-165-scripts branch October 17, 2017 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants