[WIP] Enable split meshes for Newton-based FV solvers #30379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsayad
reviewed
Apr 23, 2025
| * for advection-related kernels. | ||
| * @param obj_params The input parameters of the object | ||
| * @param rm_params The input parameters of the relationship manager | ||
| * @param conditional_extended_layers Number of layers the will get assigned if the conditions in the function are met |
There was a problem hiding this comment.
Suggested change
| * @param conditional_extended_layers Number of layers the will get assigned if the conditions in the function are met | |
| * @param conditional_extended_layers Number of layers that will get assigned if the conditions in the function are met |
| * for diffusion-related kernels. | ||
| * @param obj_params The input parameters of the object | ||
| * @param rm_params The input parameters of the relationship manager | ||
| * @param conditional_extended_layers Number of layers the will get assigned if the conditions in the function are met |
There was a problem hiding this comment.
Suggested change
| * @param conditional_extended_layers Number of layers the will get assigned if the conditions in the function are met | |
| * @param conditional_extended_layers Number of layers that will get assigned if the conditions in the function are met |
|
@grmnptr just mention me when you bring this out of draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #25621