Skip to content

go1.23-24 #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 15, 2025
Merged

go1.23-24 #1041

merged 17 commits into from
May 15, 2025

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Apr 16, 2025

This PR does the following:

  • moves the minimum go version to 1.23, and
  • uses go1.24 as toolchain

@Vibhuair20
Copy link

i saw your updates in the above sdk @adecaro
using the toolchain is a great option
But you still have issues with the golanggci-lint
Can i help you fix those issues and push a pr

@adecaro
Copy link
Contributor Author

adecaro commented Apr 17, 2025

@Vibhuair20 that would be great :)

@Vibhuair20
Copy link

Can you give me a basic rundown
To work properly

@adecaro
Copy link
Contributor Author

adecaro commented Apr 17, 2025

actually, given that it might be more complicated on the token-sdk, could you apply the same process to the smart client? Updating also the linter as I did here. What do you think?

@Vibhuair20
Copy link

Okay i think i can do the same for the smart client.

@adecaro
Copy link
Contributor Author

adecaro commented Apr 18, 2025

@Vibhuair20 , as soon as you have the PR on the smart client, I'll update the go.mod here.

go.mod Outdated
@@ -1,6 +1,8 @@
module github.com/hyperledger-labs/fabric-token-sdk

go 1.22.6
go 1.23.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be best to depend on 1.23.8 (or whichever is the latest now) to have the security fixes included.

Copy link
Contributor

@alexandrosfilios alexandrosfilios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adecaro added 12 commits May 15, 2025 13:20
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
adecaro added 5 commits May 15, 2025 13:21
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
Signed-off-by: Angelo De Caro <angelo.decaro@gmail.com>
@alexandrosfilios alexandrosfilios merged commit 04ed543 into main May 15, 2025
55 checks passed
@alexandrosfilios alexandrosfilios deleted the f-go1.23-24 branch May 15, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants