Skip to content

net2 has been deprecated, use socket2 instead #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Shadow53 opened this issue May 18, 2020 · 3 comments · Fixed by #2206
Closed

net2 has been deprecated, use socket2 instead #2205

Shadow53 opened this issue May 18, 2020 · 3 comments · Fixed by #2206
Labels
A-dependencies Area: library dependencies. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@Shadow53
Copy link

A GitHub action using RUSTSEC recently created an issue with the above description on a project I work on, and I thought I would inform the dependencies that use net2. Here's a link to the related advisory.
@Shadow53 Shadow53 mentioned this issue May 18, 2020
Open
@seanmonstar
Copy link
Member

We can certainly upgrade (I don't quite understand why it's that relevant to rust-sec 🤷).

@Shadow53
Copy link
Author

I'm not very familiar with rust-sec, but maybe the authors requested it because it's fairly commonly used? 🤷‍♂️ Glad you're aware of the deprecation, though.

@stephank stephank mentioned this issue May 18, 2020
Closed
@Nemo157 Nemo157 mentioned this issue May 18, 2020
Closed
@seanmonstar seanmonstar added A-dependencies Area: library dependencies. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-refactor Category: refactor. This would improve the clarity of internal code. labels May 18, 2020
@jyn514
Copy link
Contributor

jyn514 commented May 18, 2020

I can help work on this.

jyn514 added a commit to jyn514/hyper that referenced this issue May 18, 2020
@jyn514
Switch from net2 to socket2
7694418 
Closes hyperium#2205
@jyn514 jyn514 mentioned this issue May 18, 2020
Merged
jyn514 added a commit to jyn514/hyper that referenced this issue May 18, 2020
@jyn514
Switch from net2 to socket2
71e609c 
Closes hyperium#2205
jyn514 added a commit to jyn514/hyper that referenced this issue May 18, 2020
@jyn514
chore(client) Switch from net2 to socket2
1f36f61 
Closes hyperium#2205
jyn514 added a commit to jyn514/hyper that referenced this issue May 18, 2020
@jyn514
chore(client) switch from net2 to socket2
1312887 
Closes hyperium#2205
jyn514 added a commit to jyn514/hyper that referenced this issue May 18, 2020
@jyn514
chore(client) switch from net2 to socket2
567060b 
net2 was recently deprecated; socket2 is the recommended alternative

Closes hyperium#2205
seanmonstar pushed a commit that referenced this issue May 19, 2020
refactor(client): switch from net2 to socket2 (#2206)
d5b0ee5 
net2 was recently deprecated; socket2 is the recommended alternative

Closes #2205
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this issue Jul 26, 2021
refactor(client): switch from net2 to socket2 (hyperium#2206)
7fe77eb 
net2 was recently deprecated; socket2 is the recommended alternative

Closes hyperium#2205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: library dependencies. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from net2 to socket2 jyn514/hyper
3 participants
@seanmonstar @Shadow53 @jyn514