Fix lint from #1421 #1437
Merged
Fix lint from #1421 #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c and
ngxson
as code owners
pcuenca
commented
May 7, 2025
| @@ -137,7 +137,7 @@ export function findNearestQuantType( | |||
| // This means finding the largest quantization that is smaller than or equal to the target. | |||
| for (const availableQuant of sortedAvailable) { | |||
| // We know the key exists due to the filter above. | |||
| const availableIndex = orderMap.get(availableQuant)!; | |||
| const availableIndex = orderMap.get(availableQuant) ?? 0; | |||
There was a problem hiding this comment.
I suppose it doesn't matter what number we put here, but there could be a more idiomatic way cc @ngxson
coyotte508
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linter tests passed in #1421, but then they fail with
Forbidden non-null assertiononmainafter merging new PRs.