Added worker version for Go #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euan Torano <euantorano@gmail.com>
|
Uuuh, that's cleaner. Thanks for the PR. 👍 |
|
Sure, I can do that tomorrow night 😄 |
|
Ping. 😉 |
|
Errata added @mre - sorry for the delay 😄 |
|
Great! Thanks for your contribution @euantorano. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a slightly modified version of the Go program for episode 9 which uses a worker pool and only creates as many goroutines as there are logical threads on the system.
The Rust version seems to act similarly - Rayon will only start one thread per CPU for the
par_iter()as far as I understand it.I haven't done any benchmarking to compare times between this and the
fixed.goversion, but thought it might be nice to see another approach to the problem, similar to #45.