Skip to content

try enable brittany #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Dec 12, 2021

This is a try what would happen if to enable brittany through the project means.

@pepeiborra
Copy link
Collaborator

Well spotted, thanks!

You will need to fix all the stack descriptors and modify the following line:

if flag(brittany) && (impl(ghc < 9.0.1) || flag(ignore-plugins-ghc-bounds))

@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Dec 12, 2021

Well, brittany release for 9.0.1 has aeson >= 2.0.1, & lsp-types currently has aeson < 1.6 bound (lsp-types already had release with aeson 2.0 support but due to something made a revision). Opened haskell/lsp#373 to remind on this.

@Anton-Latukha Anton-Latukha mentioned this pull request Dec 12, 2021
35 tasks
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Dec 12, 2021

Considering it is more efficient to close this, to free space for future more complete update continuations from community.

@jneira
Copy link
Member

jneira commented Dec 13, 2021

I am continuing this in https://github.com/jneira/haskell-language-server/tree/brittany-9.0.1
It will need a massive amount of changes to make hls support aeson >= 2.0.1 (see ennocramer/floskell#68 for example)

@jneira jneira mentioned this pull request Dec 13, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants