Skip to content

🔀 Switched to python-bitbucket from defunct bitbucket-api lib #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

guyzmo
Copy link
Owner

@guyzmo guyzmo commented Nov 30, 2016

  • 🚧 switch implementation
  • 🚧 updated tests
  • 📼 updated cassettes
  • ⚠️ missing Fork implementation

fixes #43
fixes #11
fixes #13

Signed-off-by: Guyzmo guyzmo+github@m0g.net

* 🚧 switch implementation
* 🚧 updated tests
* 📼 updated cassettes
* ⚠️ missing Fork implementation

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
@guyzmo guyzmo added this to the 1.9 milestone Nov 30, 2016
@guyzmo guyzmo self-assigned this Nov 30, 2016
@guyzmo guyzmo force-pushed the features/bitbucket-refactor branch from 5bebbc3 to 5a373d1 Compare November 30, 2016 12:28
@guyzmo guyzmo force-pushed the features/bitbucket-refactor branch 2 times, most recently from caf78e8 to 3b6854d Compare November 30, 2016 15:54
@guyzmo
Copy link
Owner Author

guyzmo commented Nov 30, 2016

Here's the implementation of pybitbucket+fork in git-repo (using my own branch for the merge request).

As you can see, @ibuchanan I also had to loosen a lot the dependencies for it to work. Main conflicts were on uritemplate (which has the same API you're using between 0.6 and 3.0), requests and oauthlib. As I'm integrating with sigmavirus24/github3.py and gpocentex/python-gitlab as well, all three libraries have much libraries in common, and might be tested against different versions.

If one lib puts too much constraint on a lib, it might conflict with other libs and make git-repo uninstallable. ☹

Anyway, @ibuchanan, this PR is on hold until you merge changes to add fork() and have loosen dependencies ☺

@guyzmo guyzmo force-pushed the features/bitbucket-refactor branch from 3b6854d to d31f0b9 Compare December 2, 2016 16:15
Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
@guyzmo guyzmo force-pushed the features/bitbucket-refactor branch from 857cf1d to 052d649 Compare December 25, 2016 23:57
@guyzmo guyzmo force-pushed the features/bitbucket-refactor branch 2 times, most recently from 142743b to a7f98f2 Compare December 26, 2016 00:58
…ttes

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
@guyzmo guyzmo force-pushed the features/bitbucket-refactor branch from a7f98f2 to fe7c4d7 Compare December 26, 2016 01:06
@guyzmo guyzmo added ready and removed in progress labels Dec 26, 2016
@guyzmo
Copy link
Owner Author

guyzmo commented Apr 28, 2017

rebased and merged.

@guyzmo guyzmo closed this Apr 28, 2017
@guyzmo guyzmo removed the ready label Apr 28, 2017
guyzmo added a commit that referenced this pull request May 8, 2017
First anniversary release 🎂

This release marks the first anniversary
and 10th release of git-repo 🎉

Now git-repo supports 6 git services:

  github, gitlab, bitbucket,
  gogs, gitea and gitbucket

It supports the following commands:

  clone, fork, create, delete,
  add, open, ls, request, gist

And it's becoming relatively stable
(keep sending bug reports 🙏)

♥ Contributors

Thanks to @kounoike for the gitbucket support 🙌

Now there are three contributors promoted to collaborators:

* @kounoike, @pyhedgehog and @Crazybus

🚧 Features

* When add has no parameters, add default remote #100 #141
* When add has 'upstream' parameter, add the upstream remote #99 #141
* Use default branch instead of hardcoded 'master' #91
* Refactor and complete bitbucket support #43 #11 #80 #14 #89 #90 #79
* Loosen versions of dependencies #133
* Report if the service is already setup #136
* Adds GitBucket support #142 #144
* Adds support for ssh:// URL #148

🚒 Bugfixes

* fix various crashes #152
* fix gitlab clone crash #129
* fix request create command #147 #127
* fix request fetch command #138 #131
* fix wizard crash #149
* fix mishandling of renamed gitlab project urls #137

📝 Documentation

* documentation #145

Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant