Skip to content

Fork from yourself throws incorrect error #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pyhedgehog opened this issue Dec 22, 2016 · 1 comment · Fixed by #86
Closed

Fork from yourself throws incorrect error #84

pyhedgehog opened this issue Dec 22, 2016 · 1 comment · Fixed by #86
Assignees
Labels

Comments

@pyhedgehog
Copy link
Contributor

# git hub -v fork pyhedgehog/pygogs
Fatal error: name 'ResourceError' is not defined
------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/git_repo/repo.py", line 544, in main
    return GitRepoRunner(args).run()
  File "/usr/lib/python3.4/site-packages/git_repo/kwargparse.py", line 68, in run
    return self._action_dict[frozenset(args)](self)
  File "/usr/lib/python3.4/site-packages/git_repo/repo.py", line 329, in do_fork
    service.run_fork(self.user_name, self.repo_name, branch=self.branch)
  File "/usr/lib/python3.4/site-packages/git_repo/services/service.py", line 300, in run_fork
    raise ResourceError("Cannot fork a project from yourself.")
NameError: name 'ResourceError' is not defined
@guyzmo guyzmo self-assigned this Dec 23, 2016
@guyzmo
Copy link
Owner

guyzmo commented Dec 23, 2016

👌 and thank you!

I've replicated this, and I'll fix that ASAP!

guyzmo added a commit that referenced this issue Dec 23, 2016
fixes #85
fixes #84

Signed-off-by: Guyzmo <guyzmo+github@m0g.net>
guyzmo added a commit that referenced this issue Dec 28, 2016
🚧 Features

* Support for insecure connection through config option (fixes #66)
* Made gitlab feature complete:
 * Added support for list command in gitlab (cf #78)
 * Added support for gitlab gists (fixes #12)
 * Added support for gitlab merge requests (fixes #10)

🚒 Bugfixes

* Bad exceptions handling mistakes (fixes #84, fixes #85)
* Missing edge case handling in list command (fixes #83)

💄 Cosmetics

* Updated README with new config option
* Added @rnestler to contributors
* Updated TODO list

Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants