[Security] Add verification logic using SPIFFE Bundle Maps in XDS #8229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait for an LGTM from @matthewstevenson88 before making a pass. |
gtcooke94
commented
Apr 10, 2025
matthewstevenson88
approved these changes
Apr 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8229 +/- ##
==========================================
+ Coverage 81.98% 82.04% +0.06%
==========================================
Files 410 412 +2
Lines 40382 40564 +182
==========================================
+ Hits 33107 33282 +175
- Misses 5895 5899 +4
- Partials 1380 1383 +3
🚀 New features to boost your workflow:
|
matthewstevenson88
approved these changes
Apr 16, 2025
easwars
reviewed
Apr 17, 2025
easwars
approved these changes
Apr 22, 2025
| authType := pr.AuthInfo.AuthType() | ||
| switch wantSecLevel { | ||
| case e2e.SecurityLevelNone: | ||
| // if pr.AuthInfo.AuthType() != "insecure" { |
There was a problem hiding this comment.
Please remove the commented out line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using SPIFFE Bundle Maps for verification in XDS clients and servers.
As part of this, setting
cfg.VerifyPeerCertificatemoved fromxds.gotohandshake_info.gobecause of how the layering works with accessing the SPIFFE Bundle Map of roots - note, this makes the diff a touch harder to read.See the gRFC for more detail grpc/proposal#462
RELEASE NOTES: N/A