fix(v2): allow empty ring in segment-writer client #4124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
approved these changes
Apr 21, 2025
korniltsev
reviewed
Apr 21, 2025
kolesnikovae
force-pushed
the
fix/segment-writer-empty-ring
branch
from
1efc970 to
43f6459
Compare
kolesnikovae
force-pushed
the
fix/segment-writer-empty-ring
branch
from
43f6459 to
e2db57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #4121: In all-in-one mode, the segment writer might not be available when the distributor attempts to start. Therefore, the "empty ring" situation is expected. Eventually, once all components are initialized, the client will establish connections.
A proper solution would be to introduce component dependencies for the all-in-one mode (e.g., the distributor should wait for ingesters, and so on) in addition to module dependencies.