Skip to content

Image Render: Support tracing #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

lucychen-grafana
Copy link
Contributor

@lucychen-grafana lucychen-grafana commented Mar 12, 2025

Second attempt to add tracing. Updates from the original PR:

  • Do not add tracing headers when tracing is disabled
  • Do not add tracing headers for requests that go to a different hostname than the original request: that is not the most elegant solution but there is no easy way in Puppeteer to add headers only for specific requests (see How to set header in puppeter just main page request not all request puppeteer/puppeteer#2627). Maybe we could remove it in the feature if we fix the issue we had on Cloud and if that's not impacting other users or make it configurable but I'd like to start with this to unblock us.

To see only the changes from the original PR: https://github.com/grafana/grafana-image-renderer/compare/tmp-tracing-base...lucychen/add_tracing_fix?expand=1

lucychen-grafana and others added 14 commits March 12, 2025 16:16
* Add tracing

* changed url ingestion and tried to extract traceparent

* removing unused code

* remove unused packages and add logs

* add tracing info to logs and tracing configuration

* fix config override

* fix argv.config

* fix trace initialization and starting

* remove custom log format

* update json

* change url to env

* Apply suggestions from code review

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>

* fix yarn file

* prettier lint

* add custom trace for browser

* propagate traces back to Grafana

* Add tracing to plugin mode and improve config management (#602)

* add tracing to plugin mode

* update dev.json

* update imports

* add tracing in CSV endpoints

* fix tests

* fix and simplify config

* fix test

* update config for docker

* add to readme

* update readme

* update readme

* prettier

* update tracing

* change config and docs

* Update src/plugin/v2/grpc_plugin.ts

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>

* create new docker-compose for tracing

* add serviceName to config

* update yarn

* Apply suggestions from code review

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>

* remove env servicename

---------

Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>
Co-authored-by: AgnesToulet <35176601+AgnesToulet@users.noreply.github.com>
* update cve

* remove libraries chromium has
Bumps [axios](https://github.com/axios/axios) from 1.7.4 to 1.8.2.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.7.4...v1.8.2)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add swiftshader

* add flag

---------

Co-authored-by: Joshua Adkins <adkins@berkeley.edu>
* Docker: Remove unused NPM files

* cleanup
@lucychen-grafana lucychen-grafana linked an issue Apr 18, 2025 that may be closed by this pull request
@AgnesToulet AgnesToulet marked this pull request as ready for review April 29, 2025 11:28
@AgnesToulet AgnesToulet changed the title Image Render: Fix Tracing Image Render: Support tracing Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render: Support tracing
3 participants