Skip to content

test: improve test coverage to 96%, remove unused FEATURES properties #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 6, 2022
Merged

test: improve test coverage to 96%, remove unused FEATURES properties #456

merged 9 commits into from
Jan 6, 2022

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jan 5, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #392 🦕

@tswast tswast requested a review from a team January 5, 2022 22:45
@tswast tswast requested a review from a team as a code owner January 5, 2022 22:45
@tswast tswast requested a review from shollyman January 5, 2022 22:45
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jan 5, 2022
@tswast tswast mentioned this pull request Jan 5, 2022
Merged
4 tasks
@tswast tswast mentioned this pull request Jan 5, 2022
Open
@tswast tswast changed the title test: improve test coverage by 1%, remove unused FEATURES properties test: improve test coverage to 96%, remove unused FEATURES properties Jan 5, 2022
@tswast tswast merged commit 8b03b58 into main Jan 6, 2022
@tswast tswast deleted the bump-coverage branch January 6, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @shollyman