Skip to content

feat: adds ability to provide redirect uri #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 11, 2023
Merged

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Dec 8, 2022

WIP PR for discussion: aiming to provide the ability to include a redirect URI, client ID, and client secrets to facilitate the migration away from "out of band" OAuth authentication.

@tswast

For context, there are changes in these repos:

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Dec 8, 2022
@chalmerlowe chalmerlowe requested a review from tswast December 21, 2022 21:10
@chalmerlowe chalmerlowe self-assigned this Dec 21, 2022
@chalmerlowe
Copy link
Collaborator Author

These failing tests are due to the fact that pydata-google-auth also needs a matching update and that PR (noted above) has not been merged into the main project yet. When that is merged, the expectation is that these tests will pass.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 3, 2023
@alvarowolfx alvarowolfx self-requested a review January 3, 2023 19:59
@tswast tswast marked this pull request as ready for review January 11, 2023 16:40
@tswast tswast requested a review from a team as a code owner January 11, 2023 16:40
@tswast tswast requested a review from a team January 11, 2023 16:40
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 11, 2023
@tswast tswast merged commit a06085e into main Jan 11, 2023
@tswast tswast deleted the oauth-testing-mode-2 branch January 11, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants