Skip to content

feat: adds ability to provide redirect uri #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

chalmerlowe
Copy link

@chalmerlowe chalmerlowe commented Dec 8, 2022

WIP PR for discussion: aiming to provide the ability to include a redirect URI, client ID, and client secrets to facilitate the migration away from "out of band" OAuth authentication.

@tswast

See also changes in these repos:

@chalmerlowe chalmerlowe requested a review from tswast December 21, 2022 21:10
@chalmerlowe chalmerlowe self-assigned this Dec 21, 2022
@chalmerlowe chalmerlowe marked this pull request as ready for review January 4, 2023 21:22
@chalmerlowe chalmerlowe requested review from a team as code owners January 4, 2023 21:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 6, 2023
@Bluscream
Copy link

Any news on this? The python SDK is so broken at this point, i can't wait for HomeAssistant to release their Voice thingy

@tswast
Copy link
Contributor

tswast commented Jan 24, 2023

@Bluscream We decided not to pursue changes to this library. Instead, we have documented some workarounds here: https://github.com/googleapis/python-bigquery-pandas/pull/603/files?short_path=f498181#diff-f4981811276e52b4cea887eb3415ceae01fdb6a197138dfb8797628e62757a54

@C0t300
Copy link

C0t300 commented Jul 11, 2023

I think it's weird how you don't want any changes to the library as there's some(or all) functionality that doesn't work unless you manually set the redirect_uri, which is explicitly explained in the developers docs but not here.

@tswast
Copy link
Contributor

tswast commented Oct 4, 2023

We worked around this limitation in pydata/pydata-google-auth#58 by implementing our own "run console" style method.

@tswast tswast closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants