docs: explicitly describe that the migrate command automatically migrate linters.presets
#5697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inters of the presets to the `linters.enable` field
|
Hey, thank you for opening your first Pull Request ! |
|
|
kyu08
changed the title
linters.enable fieldmigrate command writes individual linters of the presets to the linters.enable field
kyu08
changed the title
migrate command writes individual linters of the presets to the linters.enable fieldmigrate command automatically adds individual linters to linters.enable
ldez
changed the title
migrate command automatically adds individual linters to linters.enablemigrate command automatically migrate linters.presets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining golangci-lint always!
golangci-lint helps me and my team prevent bugs by making static analysis easy to execute. 👏
When I read the migration guide to
v2, I wondered, "How should I migrate preset linters to v2 config file? Should I indentify what linters belong to the preset, and write out each linter name tov2config file one by one?".After executing the
migratecommand, I realized themigratecommand did it instead of me. 😂I believe it would be easier to understand if this were described in migration guide.
So I suggest adding description that shows the
migratecommand automatically migrateslinters.presetstolinters.enable.