-
Notifications
You must be signed in to change notification settings - Fork 18k
net/http: add Pattern field in Request to return matched pattern info #66618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: add Pattern field in Request to return matched pattern info #66618
Conversation
a243fc3
to
6cec642
Compare
This PR (HEAD: 6cec642) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
6cec642
to
e68048d
Compare
This PR (HEAD: e68048d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Zhidong Chen: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Damien Neil: Patch Set 2: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Zhidong Chen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Damien Neil: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
This PR (HEAD: ac8c2d9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
This PR (HEAD: 1439e2f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Damien Neil: Patch Set 4: Hold+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
1439e2f
to
d3c9191
Compare
This PR (HEAD: d3c9191) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Zhidong Chen: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
d3c9191
to
2eecc0a
Compare
This PR (HEAD: 2eecc0a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Zhidong Chen: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 6: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 6: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 6: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-15T21:11:43Z","revision":"b5998842000a6b37c9707ec65c94e341b80b7347"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 6: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Damien Neil: Patch Set 6: -Hold Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
2eecc0a
to
264b3ca
Compare
This PR (HEAD: 264b3ca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Zhidong Chen: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
264b3ca
to
611e04d
Compare
Message from Damien Neil: Patch Set 7: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
This PR (HEAD: 611e04d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Zhidong Chen: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
611e04d
to
c6e3274
Compare
Message from Damien Neil: Patch Set 8: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 8: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Zhidong Chen: Patch Set 8: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
This PR (HEAD: c6e3274) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574997. Important tips:
|
Message from Jonathan Amsterdam: Patch Set 9: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-16T16:36:36Z","revision":"6545b6c99e95835d1b70128c221c91c1d2068a6b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Damien Neil: Patch Set 9: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 9: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 9: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Jonathan Amsterdam: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Damien Neil: Patch Set 10: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-16T16:47:14Z","revision":"29e3205c20865b89a3c33e819386f214899a9e10"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Damien Neil: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 10: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
Fixes #66405 Change-Id: Icd80944b6ca081aa7addd4fb85d2b3c29b6c9542 GitHub-Last-Rev: c6e3274 GitHub-Pull-Request: #66618 Reviewed-on: https://go-review.googlesource.com/c/go/+/574997 Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Message from Jonathan Amsterdam: Patch Set 10: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574997. |
This PR is being closed because golang.org/cl/574997 has been merged. |
Fixes #66405