-
Notifications
You must be signed in to change notification settings - Fork 18k
crypto/x509: add text and binary marshal methods to OID #66599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 41ee9d7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-29T16:48:33Z","revision":"6bbbb9b1312254198da6d6420b934826bc23f78a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
This PR (HEAD: cb9b659) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
This PR (HEAD: c96f02b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-29T17:32:46Z","revision":"f82867d48c331d8f1911c653059df563938492d1"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
This PR (HEAD: 3b2d4df) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
This PR (HEAD: 7cf4baf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Message from Rob Pike: Patch Set 5: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from qiulaidongfeng: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-05T09:36:51Z","revision":"d14a67deef7e4582f23fc71d2ac26f3d1057195f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from qiulaidongfeng: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 5: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
7cf4baf
to
e23c539
Compare
This PR (HEAD: e23c539) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T11:48:08Z","revision":"acfde80ca8216a0602925d7c73751f830fba4a8f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
This PR (HEAD: 909911a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 6: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Change-Id: I4e335d38d861d7d672aeb8bcb2a82fc1ff557cc2
Change-Id: I4a1bd2c5edcc9524b110ad900079c10c7ab41aa1
Change-Id: Ifc1bc16df2d620c84e4321209456b1168bf11470
18fac89
to
3d4612d
Compare
This PR (HEAD: 3d4612d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 8: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 8: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-01T18:35:34Z","revision":"954366e87946b7facc8ad7595fa78b3942e75d51"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Mateusz Poliwczak: Patch Set 8: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 8: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 8: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Change-Id: I1337c57b64e7c1b709b5adf71584891fb559ff83
This PR (HEAD: e121ef3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Change-Id: I556f15de43293e79a0c4f85f4d9372009aeacd91
08b906f
to
921ca8b
Compare
Message from Roland Shoemaker: Patch Set 9: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
This PR (HEAD: 921ca8b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575295. Important tips:
|
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-15T17:28:43Z","revision":"eb0e9faedd5e0a86ba6acd4e3d058e5b783a0462"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Roland Shoemaker: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Mateusz Poliwczak: Patch Set 10: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-15T17:37:43Z","revision":"f0a572f6c36fc65b561e90e68aa33cc08337dd5a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Roland Shoemaker: Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Roland Shoemaker: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Mateusz Poliwczak: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 10: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575295. |
Fixes #66249 Change-Id: I5973a19a087a35ad951e8a220d3e6e4456c7577f GitHub-Last-Rev: 921ca8b GitHub-Pull-Request: #66599 Reviewed-on: https://go-review.googlesource.com/c/go/+/575295 Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Auto-Submit: Roland Shoemaker <roland@golang.org>
This PR is being closed because golang.org/cl/575295 has been merged. |
Fixes #66249