Skip to content

trivial time_t vs long in ar.c #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Nov 11, 2009 · 2 comments
Closed

trivial time_t vs long in ar.c #40

gopherbot opened this issue Nov 11, 2009 · 2 comments

Comments

@gopherbot
Copy link
Contributor

by smcpolin:

What steps will reproduce the problem?
1. install on freebsd
2. ./all.bash
3.

What is the expected output? What do you see instead?
pointer type violation on line 1222 of gopack/ar.c


What is your $GOOS?  $GOARCH?
nacl, 386
Which revision are you sync'ed to?  (hg log -l 1)


changeset:   3975:b51fd2d6c160
tag:         tip
user:        Kevin Ballard <kevin@sb.org>
date:        Tue Nov 10 20:05:24 2009 -0800
summary:     Implement new emacs command M-x gofmt


Which revision are you sync'ed to?  (hg log -l 1)


Please provide any additional information below.
Line 1222 should be something like:
time_t rt = bp->date; cp = ctime(&rt);
@agl
Copy link
Contributor

agl commented Nov 11, 2009

Comment 1:

This issue was closed by revision 5281869.

Status changed to Fixed.

Merged into issue #-.

@gopherbot
Copy link
Contributor Author

Comment 2:

CL https://golang.org/cl/139740043 mentions this issue.

minux pushed a commit to minux/goios that referenced this issue Feb 27, 2015
The previous logic was confused, because it assumed p->to.offset
was purely the desired frame size, whereas we encode in the high word
unspecified args size as 0x80000000. The logic infered that every function
with unspecified args size was a leaf.

Fixes golang#40
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants