pgx: don't use database/sql interface #1198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
approved these changes
Nov 29, 2024
it'd be nice to have contexts for many of these methods, but that'd be a much wider change
See also #1132. |
dhui
reviewed
Apr 17, 2025
| isLocked atomic.Bool | ||
|
|
||
| // Open and WithInstance need to guarantee that config is never nil | ||
| config *Config | ||
| } | ||
|
|
||
| func WithInstance(instance *sql.DB, config *Config) (database.Driver, error) { | ||
| func WithInstance(instance *pgx.Conn, config *Config) (database.Driver, error) { |
There was a problem hiding this comment.
This is a breaking change. Can you convert the sql.DB to a pgx.Conn internally?
There was a problem hiding this comment.
Might be good to expose a new method for people who want to pass *pgx.Conn directly
You can get *pgx.Conn from *sql.DB potentially with conn, ok := db.Conn().(*pgx.Conn)
There was a problem hiding this comment.
Looking into, db.Conn() is itself a wrapper around the driver provided connection. & does not expose handing off underlying connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it'd be nice to have contexts for many of these methods, but that'd be a much wider change