Skip to content

Fix printing packets references to use Debug instead of Ber #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

hahmadia
Copy link
Contributor

@hahmadia hahmadia commented Nov 28, 2019

This is useful for those who fork this repo and change debug's printpacket to use ber.WritePacket instead. that way we only need make a change in one place of code and we don't need change it everywhere else. Makes it more consistent

Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - thank you.

@johnweldon johnweldon merged commit 34eb223 into go-ldap:master Nov 29, 2019
@hahmadia hahmadia deleted the print_ref_fix branch November 29, 2019 23:36
vanackere pushed a commit to trustelem/ldap that referenced this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants