-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix Issue Unsubscription #9634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue Unsubscription #9634
Conversation
I'd recommend popping a comment on explaining why this one differs from the other watcher functions and needs to get the negative watchers too. |
otherwise LGTM |
Codecov Report
@@ Coverage Diff @@
## master #9634 +/- ##
=========================================
Coverage ? 42.22%
=========================================
Files ? 582
Lines ? 77103
Branches ? 0
=========================================
Hits ? 32557
Misses ? 40546
Partials ? 4000 Continue to review full report at Codecov.
|
ready to merge 🚀 |
since #9535 will take it's time ...
a quick fix
how to reproduce the bug:
and for the api (witch use this function
GetIssueWatchers
too) https://github.com/go-gitea/gitea/blob/master/models/issue_watch.go#L116 take kare of it ...