Skip to content

[Docs] Linux Service Edit #9633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 8, 2020
Merged

[Docs] Linux Service Edit #9633

merged 10 commits into from
Jan 8, 2020

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Jan 7, 2020

Per title:

  • Rename the h3 title to be more generic
  • Invite to edit config files, instead of running sudo vim
  • Use systemctl enable --now instead of running systemctl enable and systemctl start separately

bagasme added 4 commits January 7, 2020 17:50
@bagasme
Rename h3 title
91a56fb
@bagasme
Add intro
3737153 
Should work on Ubuntu Xenial, but should work on any Linux distros.
@bagasme
Indirect edit files
2ea2ea1 
Instead of providing `sudo vim`, invite to edit files.
@bagasme
enable now instead of enable and start
eb65892
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2020
@codecov-io
Copy link

codecov-io commented Jan 7, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c928863). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9633   +/-   ##
=========================================
  Coverage          ?   42.18%           
=========================================
  Files             ?      583           
  Lines             ?    77238           
  Branches          ?        0           
=========================================
  Hits              ?    32586           
  Misses            ?    40643           
  Partials          ?     4009
Impacted Files Coverage Δ
modules/setting/queue.go 79.41% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c928863...e676a50. Read the comment docs.

6543
6543 requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortcuts are good for those who already know ...

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jan 8, 2020
@bagasme bagasme requested a review from 6543 January 8, 2020 07:35
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2020
sapk
sapk reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@sapk sapk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that the `` miss click will redo the review. sorry.

sapk
sapk reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@sapk sapk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The such as vim doesn't add any value to the docs. Users that edit service file should know what is an editor.

@bagasme @sapk
Apply suggestions from @sapk
91d59a2 
Strip `vim` from editor usage

Co-Authored-By: Antoine GIRARD <sapk@users.noreply.github.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2020
@sapk sapk merged commit b822518 into go-gitea:master Jan 8, 2020
@bagasme bagasme deleted the docs/linux-service-edit branch January 13, 2020 12:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bagasme @codecov-io @sapk @6543 @lunny @GiteaBot