Skip to content

Split sendCreateCommentAction as two parts, one for update comment related informations, another for actions #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 2, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 2, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #8784 into master will decrease coverage by 0.02%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8784      +/-   ##
==========================================
- Coverage   41.27%   41.24%   -0.03%     
==========================================
  Files         544      544              
  Lines       69839    69855      +16     
==========================================
- Hits        28824    28812      -12     
- Misses      37328    37359      +31     
+ Partials     3687     3684       -3
Impacted Files Coverage Δ
models/review.go 58.46% <0%> (-1.31%) ⬇️
models/issue_comment.go 47.86% <55.55%> (-0.12%) ⬇️
modules/indexer/indexer.go 44.73% <0%> (-10.53%) ⬇️
modules/avatar/avatar.go 48% <0%> (-6%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_indexer.go 66.54% <0%> (-1.82%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
routers/repo/view.go 37.71% <0%> (-0.88%) ⬇️
modules/sync/unique_queue.go 89.28% <0%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72aa5a2...3e88406. Read the comment docs.

@lafriks lafriks added this to the 1.11.0 milestone Nov 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2019
@lafriks lafriks merged commit 12170d2 into go-gitea:master Nov 6, 2019
@lunny lunny deleted the lunny/comment_action branch November 6, 2019 13:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants