Skip to content

Add license scan report and status #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

fossabot
Copy link

Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.

Below are docs for integrating FOSSA license checks into your CI:

Signed-off-by: fossabot <badges@fossa.io>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7ffa3fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7849   +/-   ##
=========================================
  Coverage          ?   41.39%           
=========================================
  Files             ?      474           
  Lines             ?    63780           
  Branches          ?        0           
=========================================
  Hits              ?    26399           
  Misses            ?    33942           
  Partials          ?     3439

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffa3fc...7195653. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 14, 2019
@lafriks
Copy link
Member

lafriks commented Aug 14, 2019

I don't think readme is right place for such report

@lunny
Copy link
Member

lunny commented Aug 14, 2019

@lafriks but it seems all other repositories put that link on README.

@lafriks
Copy link
Member

lafriks commented Aug 14, 2019

We should first add this as drone task then to update this data from master

@lafriks
Copy link
Member

lafriks commented Aug 14, 2019

imho it still looks kind of messy. It does show licenses also of dependency tool licenses that we really don't care much, it does not correctly detect license of cobra library

@gary-kim
Copy link
Member

I use FOSSA in one of my projects and from my experience, mismatched licenses and false positives do happen often and will need to be dealt with.

@stale
Copy link

stale bot commented Oct 13, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 13, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Oct 13, 2019
@stale stale bot removed the issue/stale label Oct 13, 2019
@lunny
Copy link
Member

lunny commented Oct 18, 2019

@gary-kim any better tool to recommend?

@6543
Copy link
Member

6543 commented Oct 29, 2019

can we close this?

@lunny lunny closed this Oct 30, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants