Skip to content

Updates vendor/code.gitea.io/git #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

richmahn
Copy link
Contributor

@richmahn richmahn commented Mar 8, 2019

Updates the dep for code.gitea.io/git

@techknowlogick techknowlogick added type/bug topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Mar 8, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Mar 8, 2019
@techknowlogick techknowlogick requested a review from lunny March 8, 2019 23:31
@richmahn
Copy link
Contributor Author

@lunny Pending your review on how we should handle getting my changes to the git repo when you have changes in there for v1.9.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2019
@richmahn
Copy link
Contributor Author

@techknowlogick @lunny I also see the build fails due to there needing to be a change to a call to what lunny did for the cache in the gitea code.

@zeripath
Copy link
Contributor

Given the caching code seems to be able to cope with nil for the cache it's probably quickest to just change the broken bits in Gitea to pass in nil

@lunny
Copy link
Member

lunny commented Mar 11, 2019

I think this has been replaced by #6224

@zeripath
Copy link
Contributor

Actually Rich if you update this so that you use the latest git master you can fix #6292.

@codecov-io
Copy link

Codecov Report

Merging #6286 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6286   +/-   ##
=======================================
  Coverage   38.83%   38.83%           
=======================================
  Files         359      359           
  Lines       51100    51100           
=======================================
  Hits        19844    19844           
  Misses      28384    28384           
  Partials     2872     2872

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c20560...2f4e417. Read the comment docs.

@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2019
@lafriks lafriks added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 11, 2019
@lafriks lafriks removed the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 11, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 11, 2019
@techknowlogick techknowlogick merged commit 50631b5 into go-gitea:master Mar 11, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants