Extract header and footer content to separate templates #4797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
- Coverage 37.27% 37.26% -0.01%
==========================================
Files 305 305
Lines 45170 45170
==========================================
- Hits 16837 16834 -3
- Misses 25896 25898 +2
- Partials 2437 2438 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
|
There is a PR #4651 that is pending a merge that will likely require changes to be made in this PR |
|
Thanks for letting me know. If my change is accepted, I'm happy to rebase it so that you can merge it directly. :) |
|
@lukasbestle please resolve conflict |
This change makes it easier to customize the header and footer content. Before this change, the whole header and footer had to be overridden, including the meta, style and script tags. Signed-off-by: Lukas Bestle <mail@lukasbestle.com>
lukasbestle
force-pushed
the
template-customization
branch
from
bf20213 to
b921f2b
Compare
|
Done :) |
techknowlogick
approved these changes
Aug 27, 2018
bkcsoft
added
lgtm/need 1
lunny
approved these changes
Sep 7, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it easier to customize the header and footer content. Before this change, the whole header and footer had to be overridden, including the meta, style and script tags.
Apart from moving the code to separate files, there are no other changes to the templates in this PR.