Added deletion of an empty line at the end of the file (#4050) #4054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4054 +/- ##
==========================================
- Coverage 19.96% 19.96% -0.01%
==========================================
Files 153 153
Lines 30478 30482 +4
==========================================
Hits 6086 6086
- Misses 23479 23483 +4
Partials 913 913
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
|
LGTM |
bkcsoft
added
lgtm/need 1
jonasfranz
approved these changes
May 27, 2018
bkcsoft
added
lgtm/done
|
@lunny I think this issue is more an enhancement then a bug. |
|
@JonasFranzDEV I don't think so. see lines := strings.Split(fileContent, "\n")And assume we have a file a = b\n
c = d\nThis will always output 3 lines, because we used |
|
@axifive please send a backport PR to relase/v1.4 |
axifive
added a commit
to axifive/gitea
that referenced
this pull request
May 29, 2018
Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
lunny
pushed a commit
that referenced
this pull request
May 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4050
Now the same viewing behavior as the GitHub.
While viewing:
While editing:
