Drop fomantic build #33845
Merged
Drop fomantic build #33845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
refactor-fomantic
branch
from
f6c9a96 to
e5c1158
Compare
techknowlogick
added
the
topic/build
wxiaoguang
force-pushed
the
refactor-fomantic
branch
from
72bd874 to
eb500e1
Compare
wxiaoguang
force-pushed
the
refactor-fomantic
branch
from
671d396 to
e0a4ec4
Compare
delvh
approved these changes
Mar 10, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 10, 2025
GiteaBot
added
lgtm/done
|
@lunny CI failures like "docker-dryrun / rootless (pull_request)" are unrelated. And the failures keep occurring. |
wxiaoguang
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 12, 2025
* giteaofficial/main: Fix various Fomantic UI and htmx problems (go-gitea#33851) Add workflow_job webhook (go-gitea#33694) Fix file icon mapping (go-gitea#33855) Drop fomantic build (go-gitea#33845) Fix auto concurrency cancellation skips commit status updates (go-gitea#33764) Fix test code (go-gitea#33829) Remove "noscript" tag from html head (go-gitea#33846) Fix material icon & diff highlight (go-gitea#33844) Fix LFS URL (go-gitea#33840) Add material icons for file list (go-gitea#33837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would never update or build fomantic again, we have forked it as a private library long time ago.
So just put the JS and CSS files in "fomantic/build" into git. And use "import" to use them.
Remove "form.js", rewrite "tab" component.
All source code is from official Fomantic UI build. Will apply patches in separate PRs.