Skip to content

Refactor markdown attention render #29984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2024
Merged

Refactor markdown attention render #29984

merged 3 commits into from
Mar 22, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 22, 2024 •
edited
Loading

Follow #29833 and add tests

image

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 22, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Mar 22, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 22, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 22, 2024 11:49
@wxiaoguang wxiaoguang merged commit 2ff213b into go-gitea:main Mar 22, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-attention branch March 22, 2024 12:18
@lunny lunny mentioned this pull request Mar 27, 2024
Merged
wxiaoguang added a commit that referenced this pull request Mar 27, 2024
@lunny @wxiaoguang
Fix bug for markdown rendering of blockquote (#30130)
400bb7c 
Caused by #29984

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot