Skip to content

Fix missing error check of bufio.Scanner (#29882) #29896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix missing error check of bufio.Scanner (#29882) #29896

wants to merge 1 commit into from

Conversation

GiteaBot
Copy link
Collaborator

Backport #29882 by @forsaken628

maybe more

@GiteaBot GiteaBot added the modifies/go Pull requests that update Go code label Mar 19, 2024
@GiteaBot GiteaBot requested review from delvh, lunny and silverwind March 19, 2024 02:20
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2024
@GiteaBot GiteaBot added this to the 1.21.9 milestone Mar 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2024
@wxiaoguang
Copy link
Contributor

Don't backport since it is not an important "bug" fix, and no test covers it.

techknowlogick
techknowlogick requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block per comment

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2024
@lunny lunny closed this Mar 19, 2024
@GiteaBot GiteaBot removed this from the 1.21.9 milestone Mar 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick requested changes

@lunny lunny lunny approved these changes

@delvh delvh Awaiting requested review from delvh

@silverwind silverwind Awaiting requested review from silverwind

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GiteaBot @wxiaoguang @lunny @techknowlogick @forsaken628