Fix required checkboxes in issue forms #27592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Oct 12, 2023
github-actions
bot
added
modifies/templates
silverwind
approved these changes
Oct 19, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Oct 19, 2023
GiteaBot
added
lgtm/done
silverwind
added
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 19, 2023
If you set a checkbox as required in a issue form at the moment, the checkbox is checked and read only, what does not make much sense. With this PR, the Checkbox actually needs to be checked. The label supports now also Markdown. This matches GitHub's behaviour. And yes, I know the CSS is a ugly workaround. It looks like the given CSS code is part Fomantic and I don't know how to change that. The Maintainers are free to change that. 
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Oct 19, 2023
Backport #27592 by @JakobDev If you set a checkbox as required in a issue form at the moment, the checkbox is checked and read only, what does not make much sense. With this PR, the Checkbox actually needs to be checked. The label supports now also Markdown. This matches GitHub's behaviour. And yes, I know the CSS is a ugly workaround. It looks like the given CSS code is part Fomantic and I don't know how to change that. The Maintainers are free to change that.  Co-authored-by: JakobDev <jakobdev@gmx.de>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 20, 2023
* upstream/main: Adapt `.changelog.yml` to new labeling system (go-gitea#27701) Update and add new eslint plugins (go-gitea#27698) Show total TrackedTime on issue/pull/milestone lists (go-gitea#26672) Add doctor dbconsistency fix to delete repos with no owner (go-gitea#27290) Delete repos of org when purge delete user (go-gitea#27273) Fix required checkboxes in issue forms (go-gitea#27592) Upgrade xorm (go-gitea#27673) [docs] Add note that PROTOCOL config is case-sensitive (go-gitea#25685) Remove network call on `make clean` (go-gitea#27689) Add unit tests for action runner token (go-gitea#27670) Typos fixed in documentation files (go-gitea#27687)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set a checkbox as required in a issue form at the moment, the checkbox is checked and read only, what does not make much sense. With this PR, the Checkbox actually needs to be checked. The label supports now also Markdown. This matches GitHub's behaviour.
And yes, I know the CSS is a ugly workaround. It looks like the given CSS code is part Fomantic and I don't know how to change that. The Maintainers are free to change that.