Skip to content

Backport ctx locale refactoring manually (#27231) (#27259) #27260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2023
Merged

Backport ctx locale refactoring manually (#27231) (#27259) #27260

merged 2 commits into from
Sep 25, 2023

Conversation

wxiaoguang
Copy link
Contributor

Backport #27231 #27259 manually

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Sep 25, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 25, 2023
This was referenced Sep 25, 2023
Merged
Merged
silverwind
silverwind approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit risky of a backport, but I guess there's still enough testing time and this will be required to ease future backports.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2023
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 25, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 25, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) September 25, 2023 12:57
@wxiaoguang wxiaoguang merged commit 597b04f into go-gitea:release/v1.21 Sep 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 25, 2023
@wxiaoguang wxiaoguang deleted the backport-ctx-locale branch September 25, 2023 13:19
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @silverwind @denyskon @GiteaBot @delvh