Improve flex list UI #26970
Merged
Improve flex list UI #26970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
the
skip-changelog
Merged
silverwind
reviewed
Sep 8, 2023
silverwind
approved these changes
Sep 8, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Sep 8, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
I have to admit that such layout trick (flex "icon" + "title") is not good enough. For example, if there are labels .... Maybe the only way for a perfect fix is to get rid of such layout, eg: move the "icon" into the "title", let they layout together.
|
|
And even worse .... with emoji label:
|
|
I woul aim to have the baseline of the text aligned with the lower edge of the left side icon. Labels should be centered on text. While doing these tweaks, ensure wrapping onto multiple lines does not regress. |
|
-> Improve issue list layout #26983 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 9, 2023
* giteaoffical/main: [skip ci] Updated translations via Crowdin Move some functions to service layer (go-gitea#26969) Lock yamllint and update indirect python deps (go-gitea#26979) Chroma color tweaks (go-gitea#26978) Add a new column schedule_id for action_run to track (go-gitea#26975) Improve flex list UI (go-gitea#26970) Clarify the git command Stdin hanging problem (go-gitea#26967) Add v1.20.4 changelog (go-gitea#26974) Check newly added node type before "attachDirAuto" (go-gitea#26972) Expanding documentation in queue.go (go-gitea#26889) move repository deletion to service layer (go-gitea#26948)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gt-ac, so no need to introduceflex-item-centerflex-item-baselineand.flex-item-icon svg { margin-top: 1px }seem to be a tricky patch, they don't resolve the root problem, and still cause misalignment in some cases.flex-text-inlinecould only be used if the element is really "inline", otherwise itsvertical-alignwould make the box size change. In most cases,flex-text-blockis good enough.