The repository list page, pading top and bottom is too small compared as v1.20, increase them so make it looks like before #26761
Conversation
… as v1.20, increase them so make it looks like before
lunny
added
topic/ui
GiteaBot
added
the
lgtm/need 2
|
Why not just The current approach makes some UI look strange, the first item doesn't have proper padding-top. @denyskon Do you have ideas for it? |
|
It was some sort of issue if you combine flex-item and "ui attached segment", that's why I decided to set the padding only between two items. I'm not at home currently to reproduce it though..... And about this change: I'm unsure if this would look right everywhere else where we use flex-list... maybe we need to set it only for repo list if we really want 1rem padding there |
Could it be resolved by |
|
I do agree it looks better with a tiny bit more vertical margin. I would also like to add some tiny bit of horizontal margin, but I'll do that in #26552. |
Let's not create a dependeny on fomantic classes, if possible. |
The missing padding-top breaks other layout. You could take a try. I wouldn't say the paddings in |
|
It's better to keep children elements simple, and let parent containers layout the necessary padding/margin. -> Improve flex list item padding #26779 |
Replace #26761 It's better to keep children elements simple, and let parent containers layout the necessary padding/margin. The old `not(:last-child)` and `.flex-item + .flex-item` are not easy to maintain (for example, what if the developer would like to use a "tiny height" item?) The old approach also makes some UI look strange because the first item doesn't have proper padding-top. In this PR, we just simply use `.flex-item { padding: ... }`: * Developers could manually set the item height they want easily * It's easier to make it work with various containers -- with padding (`ui segment`) and without padding (`div`) And added more samples/examples.  Co-authored-by: Giteabot <teabot@gitea.io>
Before
After