refactor(API): refactor secret creation and update functionality #26751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the `CreateSecretOption` struct and replace it with `CreateOrUpdateSecretOption` in `modules/structs/secret.go` - Update the `CreateOrUpdateOrgSecret` function in `routers/api/v1/org/action.go` to use `CreateOrUpdateSecretOption` instead of `UpdateSecretOption` - Remove the `CreateOrgSecret` function in `routers/api/v1/org/action.go` and replace it with `CreateOrUpdateOrgSecret` - Update the Swagger documentation in `routers/api/v1/swagger/options.go` and `templates/swagger/v1_json.tmpl` to reflect the changes in the struct names and function names Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
GiteaBot
added
the
lgtm/need 2
lunny
added
the
type/refactoring
lunny
added
the
skip-changelog
lunny
approved these changes
Aug 28, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Aug 28, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 29, 2023
* giteaofficial/main: Add fix incorrect can_create_org_repo for org owner team (go-gitea#26683) [skip ci] Updated translations via Crowdin Improve modal dialog UI (go-gitea#26764) Improve the "bug report" template and "support options" document (go-gitea#26753) Unify `border-radius` behavior (go-gitea#26770) Reduce some allocations in type conversion (go-gitea#26772) Refactor some CSS styles and simplify code (go-gitea#26771) Add auth-required to config.json for Cargo http registry (go-gitea#26729) refactor(API): refactor secret creation and update functionality (go-gitea#26751)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the GitHub API Spec: https://docs.github.com/en/rest/actions/secrets?apiVersion=2022-11-28#create-or-update-an-organization-secret
Merge the Create and Update secret into a single API.
CreateSecretOptionstruct and replace it withCreateOrUpdateSecretOptioninmodules/structs/secret.goCreateOrUpdateOrgSecretfunction inrouters/api/v1/org/action.goto useCreateOrUpdateSecretOptioninstead ofUpdateSecretOptionCreateOrgSecretfunction inrouters/api/v1/org/action.goand replace it withCreateOrUpdateOrgSecretrouters/api/v1/swagger/options.goandtemplates/swagger/v1_json.tmplto reflect the changes in the struct names and function names