Fix incorrect link-action event target #25306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
the
skip-changelog
wxiaoguang
force-pushed
the
fix-link-action
branch
from
d9baf6a to
ea00b2c
Compare
silverwind
approved these changes
Jun 16, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jun 18, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 19, 2023
* giteaofficial/main: (22 commits) Only run `docker-dryrun` when necessary (go-gitea#25329) fix a nit error output in Makefile (go-gitea#25360) [skip ci] Updated translations via Crowdin Clean up pyproject.toml and package.json, fix poetry options (go-gitea#25327) Fix label list divider (go-gitea#25312) Avoid polluting the config (go-gitea#25345) Fix incorrect link-action event target (go-gitea#25306) Write absolute AppDataPath to app.ini when installing (go-gitea#25331) Add Exoscale to installation on cloud provider docs (go-gitea#25342) Fix UI on mobile view (go-gitea#25315) When viewing a file, hide the add button (go-gitea#25320) Update JS dependencies, remove space after emoji completion (go-gitea#25266) Refactor web package and context package (go-gitea#25298) build nightly docker images (go-gitea#25317) Add `stylelint-declaration-block-no-ignored-properties` (go-gitea#25284) Remove EasyMDE focus outline on text (go-gitea#25328) use Actions environment variables in Makefile (go-gitea#25319) add `stylelint-stylistic` (go-gitea#25285) Remove more unused Fomantic variants (go-gitea#25292) Build nightly binaries with Actions (go-gitea#25308) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression of #25210
The
e.targetis not "this", eg:<button link-action><svg></button>, thenthisshould bebuttonbute.targetissvg.I will propose a clearer and complete solution for these "link-action" "show-modal" elements after #24724